set file in kernel when we change kernel in the interactive window #4324
Conversation
in the interactive window
| }) | ||
| .then(async () => { | ||
| // Reset our file in the kernel. | ||
| const fileInKernel = this.fileInKernel; |
There was a problem hiding this comment.
I think it would actually be better to do this in the 'kernelChangedHandler' function. That would handle the case where this function isn't called (like if the command is executed from the palette).
There was a problem hiding this comment.
Not a fan of this, we have a lot of other code where we initialize the kernel once started/restarted (setting cwd, matplot lib options, jedi options, & more )
I'd prefer this was done in the same place where we do the other stuff.
| }) | ||
| .then(async () => { | ||
| // Reset our file in the kernel. | ||
| const fileInKernel = this.fileInKernel; |
There was a problem hiding this comment.
Not a fan of this, we have a lot of other code where we initialize the kernel once started/restarted (setting cwd, matplot lib options, jedi options, & more )
I'd prefer this was done in the same place where we do the other stuff.
For #4164
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).