new UI side telemetry events for variable view #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The JupyterVariables interface has some telemetry that was already hooked up and working. But on checking added some UI side telemetry for the new variable view. |
IanMatthewHuff
commented
Feb 10, 2021
| @@ -82,6 +82,7 @@ export class VariableView extends WebviewViewHost<IVariableViewPanelMapping> imp | |||
| this.dataViewerChecker = new DataViewerChecker(configuration, appShell); | |||
| } | |||
|
|
|||
| @captureTelemetry(Telemetry.NativeVariableViewLoaded) | |||
There was a problem hiding this comment.
This seemed extra useful as we are not using retain context on the webview. Means that it gets loaded fairly often. Here to make sure that this is not taking too long.
IanMatthewHuff
commented
Feb 10, 2021
| @@ -182,6 +184,9 @@ export class VariableView extends WebviewViewHost<IVariableViewPanelMapping> imp | |||
| const response = await this.variables.getVariables(args, this.notebookWatcher.activeNotebook); | |||
|
|
|||
| this.postMessage(InteractiveWindowMessages.GetVariablesResponse, response).ignoreErrors(); | |||
| sendTelemetryEvent(Telemetry.VariableExplorerVariableCount, undefined, { | |||
There was a problem hiding this comment.
This is same event in the same spot as with the old webviews, lets us see how many variables we are fetching.
rchiodo
approved these changes
Feb 10, 2021
DavidKutu
approved these changes
Feb 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #4740 +/- ##
=====================================
Coverage 76% 76%
=====================================
Files 400 400
Lines 26254 26258 +4
Branches 3768 3768
=====================================
+ Hits 20096 20144 +48
+ Misses 4597 4561 -36
+ Partials 1561 1553 -8
|
joyceerhl
approved these changes
Feb 10, 2021
|
Failure looks like the kernel switch flake issue. |
DonJayamanne
pushed a commit
that referenced
this pull request
Feb 11, 2021
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4649
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).