Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend extensions when opening notebooks #5690

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Recommend extensions when opening notebooks #5690

merged 4 commits into from
Apr 29, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #5577

@DonJayamanne DonJayamanne requested a review from a team as a code owner April 29, 2021 17:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #5690 (06b06f7) into main (aa2f524) will decrease coverage by 3%.
The diff coverage is 87%.

❗ Current head 06b06f7 differs from pull request most recent head a0f2e64. Consider uploading reports for the commit a0f2e64 to get more accurate results

@@           Coverage Diff           @@
##            main   #5690     +/-   ##
=======================================
- Coverage     72%     69%     -4%     
=======================================
  Files        401     402      +1     
  Lines      26741   26807     +66     
  Branches    3901    3910      +9     
=======================================
- Hits       19453   18549    -904     
- Misses      5641    6641   +1000     
+ Partials    1647    1617     -30     
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernels/helpers.ts 71% <75%> (-2%) ⬇️
src/client/datascience/extensionRecommendation.ts 87% <87%> (ø)
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
src/client/datascience/serviceRegistry.ts 97% <100%> (+<1%) ⬆️
...ascience/notebookStorage/notebookModelEditEvent.ts 10% <0%> (-50%) ⬇️
...ce/raw-kernel/liveshare/kernelSpecNotFoundError.ts 50% <0%> (-50%) ⬇️
.../client/datascience/plotting/plotViewerProvider.ts 38% <0%> (-48%) ⬇️
.../datascience/plotting/plotViewerMessageListener.ts 15% <0%> (-47%) ⬇️
...nt/datascience/jupyter/kernels/kernelSelections.ts 50% <0%> (-45%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 55% <0%> (-45%) ⬇️
... and 82 more

suite('DataScience Extension Recommendation', () => {
['kernelspec', 'language_info'].forEach((whereIsLanguageDefined) => {
['csharp', 'fsharp', 'powershell'].forEach((languageToBeTested) => {
suite(`Notebook langauge '${languageToBeTested}' defined in ${whereIsLanguageDefined}`, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language in comment

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One possible suggestion would be telemetry on the prompt. Knowing how much it's shown and what the users pick. Not sure if we care though.

@DonJayamanne DonJayamanne merged commit 217bda3 into main Apr 29, 2021
@DonJayamanne DonJayamanne deleted the issue5577 branch April 29, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants