-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend extensions when opening notebooks #5690
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5690 +/- ##
=======================================
- Coverage 72% 69% -4%
=======================================
Files 401 402 +1
Lines 26741 26807 +66
Branches 3901 3910 +9
=======================================
- Hits 19453 18549 -904
- Misses 5641 6641 +1000
+ Partials 1647 1617 -30
|
suite('DataScience Extension Recommendation', () => { | ||
['kernelspec', 'language_info'].forEach((whereIsLanguageDefined) => { | ||
['csharp', 'fsharp', 'powershell'].forEach((languageToBeTested) => { | ||
suite(`Notebook langauge '${languageToBeTested}' defined in ${whereIsLanguageDefined}`, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
language in comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One possible suggestion would be telemetry on the prompt. Knowing how much it's shown and what the users pick. Not sure if we care though.
For #5577