Fixes to rendering output of holoview #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Jun 3, 2021
| @@ -361,6 +361,14 @@ const orderOfMimeTypes = [ | |||
| 'application/json', | |||
| 'text/plain' | |||
| ]; | |||
| function isEmptyVendoredMimeType(outputItem: NotebookCellOutputItem) { | |||
| if (outputItem.mime.startsWith('application/vnd.')) { | |||
There was a problem hiding this comment.
Do they always start with application/vnd? Would application also apply?
There was a problem hiding this comment.
Yes, they always start with application/vnd for vendor specific mime types.
rchiodo
approved these changes
Jun 3, 2021
| let indexOfMimeTypeA = orderOfMimeTypes.findIndex((mime) => isMimeTypeMatch(mime, outputItemA.mime)); | ||
| let indexOfMimeTypeB = orderOfMimeTypes.findIndex((mime) => isMimeTypeMatch(mime, outputItemB.mime)); | ||
| // Sometimes we can have mime types with empty data, e.g. when using holoview we can have `application/vnd.holoviews_load.v0+json` with empty value. | ||
| // & in these cases we have HTML/JS and those take precedence. |
There was a problem hiding this comment.
I think this makes sense with Bokeh, I believe in the old working version it was rendering with HTML/Js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6109