couple of settings tweaks from VS Code for our tests #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found this related VS Code issue, so giving a settings recommendation from there a shot. |
rchiodo
approved these changes
Jun 14, 2021
IanMatthewHuff
commented
Jun 14, 2021
| @@ -26,5 +26,6 @@ | |||
| // We don't want jupyter to start when testing (DS functionality or anything else). | |||
| "jupyter.disableJupyterAutoStart": true, | |||
| "jupyter.logging.level": "debug", | |||
| "python.logging.level": "debug" | |||
| "python.logging.level": "debug", | |||
| "webview.experimental.useIframes": true | |||
There was a problem hiding this comment.
This was the vscode recommended setting change. They use it in their smoke tests.
microsoft/vscode#125733
DavidKutu
approved these changes
Jun 14, 2021
IanMatthewHuff
commented
Jun 14, 2021
| @@ -111,6 +111,8 @@ async function start() { | |||
| extensionTestsPath: path.join(EXTENSION_ROOT_DIR_FOR_TESTS, 'out', 'test', 'index'), | |||
| launchArgs: baseLaunchArgs | |||
| .concat([workspacePath]) | |||
| .concat(['--skip-welcome']) | |||
There was a problem hiding this comment.
Also saw these in their test files. Felt like they might be good for test stability so I added them as well.
DonJayamanne
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6234
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).