RBL code cleanup #7416
Merged
RBL code cleanup #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
force-pushed
the
roblou/cleanup
branch
from
82ea82d
to
4733f3b
Compare
Codecov Report
@@ Coverage Diff @@
## main #7416 +/- ##
======================================
- Coverage 64% 62% -2%
======================================
Files 361 362 +1
Lines 22563 22607 +44
Branches 3415 3418 +3
======================================
- Hits 14490 14149 -341
- Misses 6870 7256 +386
+ Partials 1203 1202 -1
|
| return; | ||
| } | ||
| this.trace('event', JSON.stringify(msg)); | ||
| if (!(await this.delegate?.willSendEvent(anyMsg))) { |
There was a problem hiding this comment.
Nice feels much better this way.
IanMatthewHuff
approved these changes
Sep 3, 2021
DavidKutu
approved these changes
Sep 7, 2021
DonJayamanne
reviewed
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7346
This moves most of the RBL and cell debug specific code out of KernelDebugAdapter into controller classes. There is some left that will be a separate change for the variables changes we discussed in #7346.
Has a news entry file (remember to thank yourself!).Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).