Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire onDidChangeViewState for interactive window #7596

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

joyceerhl
Copy link
Contributor

Fix #7249

The interactive window used to be a webview panel so it had its own view state change event. Needed to hook that event up to window.onDidChangeActiveNotebookEditor as we're now working with an editor instead. Comparing NotebookEditors here instead of comparing stringified URIs should be safe because they're fat objects so shouldn't be recreated in the extension host.

@joyceerhl joyceerhl requested a review from a team as a code owner September 20, 2021 23:19
@codecov-commenter
Copy link

Codecov Report

Merging #7596 (5162d8d) into main (adc3601) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #7596   +/-   ##
=====================================
  Coverage     66%     66%           
=====================================
  Files        365     365           
  Lines      22650   22652    +2     
  Branches    3440    3441    +1     
=====================================
+ Hits       15099   15104    +5     
+ Misses      6263    6258    -5     
- Partials    1288    1290    +2     
Impacted Files Coverage Δ
...atascience/interactive-window/interactiveWindow.ts 54% <100%> (+<1%) ⬆️
...ence/editor-integration/cellHashProviderFactory.ts 97% <0%> (-3%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 56% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 68% <0%> (-1%) ⬇️
...ce/interactive-window/interactiveWindowProvider.ts 72% <0%> (+1%) ⬆️
...tascience/jupyter/kernels/kernelCommandListener.ts 58% <0%> (+2%) ⬆️

@joyceerhl joyceerhl merged commit 9fb5057 into main Sep 21, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/active-iw branch September 21, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run code on specify interactive window
3 participants