Use the kernel to check for ipykernel 6 version, instead of the python installer #7689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n installer. This works for both local and remote.
DavidKutu
commented
Sep 27, 2021
|
|
||
| const checkCompatible = () => | ||
| this.pythonInstaller.isProductVersionCompatible(Product.ipykernel, '>=6.0.0', interpreter); |
There was a problem hiding this comment.
No need for caching or the python installer anymore, this is just faster.
rchiodo
approved these changes
Sep 27, 2021
DonJayamanne
approved these changes
Sep 27, 2021
IanMatthewHuff
approved these changes
Sep 27, 2021
Codecov Report
@@ Coverage Diff @@
## main #7689 +/- ##
=====================================
- Coverage 68% 68% -1%
=====================================
Files 363 363
Lines 22582 22590 +8
Branches 3435 3437 +2
=====================================
- Hits 15525 15521 -4
- Misses 5719 5727 +8
- Partials 1338 1342 +4
|
DonJayamanne
requested changes
Sep 27, 2021
|
oops, I'll open another PR |
roblourens
reviewed
Sep 27, 2021
|
|
||
| if (output[0].text) { | ||
| const majorVersion = Number(output[0].text.toString().charAt(0)); | ||
| const result = majorVersion >= 6; |
There was a problem hiding this comment.
Will work until ipykernel gets to version 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works for both local and remote.
For #7576
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).