Re-run initialization when changing kernels in iw #7948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Oct 15, 2021
| const kernel = this.kernelProvider.getOrCreate(editor.document, { | ||
| metadata: controller!.connection, | ||
| controller: controller!.controller, |
DonJayamanne
commented
Oct 15, 2021
| const notebookEditor = await this._editorReadyPromise; | ||
| const kernel = await this._kernelReadyPromise; | ||
| await this.updateOwners(fileUri); | ||
| const [notebookEditor, kernel] = await Promise.all([ |
There was a problem hiding this comment.
Parallelize, should be a little faster
DonJayamanne
commented
Oct 15, 2021
| this.internalDisposables.push(kernel); | ||
| await kernel.start(); | ||
| this.fileInKernel = undefined; | ||
| await this.runIntialization(kernel, this.owner); |
There was a problem hiding this comment.
Moved initialization scripts to after kernel is created/started.
This way it happens everytime
There was a problem hiding this comment.
Also passing the owner
rchiodo
approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #7948 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 364 364
Lines 22427 22424 -3
Branches 3416 3416
=====================================
- Hits 15882 15880 -2
+ Misses 5171 5156 -15
- Partials 1374 1388 +14
|
IanMatthewHuff
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7941
Changing controllers doesn't re-run the initialization scripts in interactive window