More progress indicator when starting a kernel #8584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Dec 20, 2021
| await Promise.race([cachedInfo, latestInfo]); | ||
| if (cachedInfo.completed && cachedInfo.value?.version) { | ||
| return (this._version = cachedInfo.value.version); | ||
| if (this._previousVersionCall) { |
There was a problem hiding this comment.
Ensure we make these calls only once
DonJayamanne
commented
Dec 20, 2021
| const title = DataScience.activatingPythonEnvironment().format( | ||
| interpreter.displayName || getDisplayPath(interpreter.path) | ||
| ); | ||
| return KernelProgressReporter.wrapAndReportProgress(resource, title, () => |
There was a problem hiding this comment.
Display progress message
DonJayamanne
commented
Dec 20, 2021
| traceInfo(`Waiting for idle on (kernel): ${session.kernel.id} -> ${session.kernel.status}`); | ||
| const progress = isRestartSession | ||
| ? undefined | ||
| : KernelProgressReporter.reportProgress( |
There was a problem hiding this comment.
Display progress messages
DonJayamanne
commented
Dec 20, 2021
| @@ -242,7 +243,7 @@ export class JupyterKernelService { | |||
| // Get the activated environment variables (as a work around for `conda run` and similar). | |||
| // This ensures the code runs within the context of an activated environment. | |||
| specModel.env = await this.activationHelper | |||
| .getActivatedEnvironmentVariables(undefined, interpreter, true) | |||
| .getActivatedEnvironmentVariables(resource, interpreter, true) | |||
There was a problem hiding this comment.
Pass resource so we can display progress message
DonJayamanne
commented
Dec 20, 2021
| // It could look as though the same operation is being performed multiple times (when in fact its possible we have caching in place). | ||
| // Eg. we could be attempting to start a python process, which requires activation, thats cached, however calling it multiple times | ||
| // could result in multiple messages being displayed. | ||
| // Perhaps its the right thing to do and display the message multiple times, but for now, we'll just not display it. |
There was a problem hiding this comment.
We can change this if required, felt weird to display the messages a number of times.
E.g. we have messages displayed as follows:
- Activating Python environment abc
- Validating kernel dependencies
- Activating Python environment abc (again)
This change ensures we display it just once.
Codecov Report
@@ Coverage Diff @@
## main #8584 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 381 381
Lines 24392 24424 +32
Branches 3745 3749 +4
=====================================
+ Hits 17384 17424 +40
+ Misses 5503 5491 -12
- Partials 1505 1509 +4
|
…scode-jupyter into addProgressIndicator * 'addProgressIndicator' of https://github.com/microsoft/vscode-jupyter: COMMIT_PERF_RESULTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8583