Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly look at the settings for the resource in question when calculating working directory. #8680

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

IanMatthewHuff
Copy link
Member

For #8561

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner January 12, 2022 23:17
@IanMatthewHuff
Copy link
Member Author

Drat, ran into Rich's change in kernel.ts. Will update....

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #8680 (310b87b) into main (c60dcfd) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #8680    +/-   ##
======================================
  Coverage     71%     71%            
======================================
  Files        384     384            
  Lines      24666   24783   +117     
  Branches    3794    3826    +32     
======================================
+ Hits       17655   17783   +128     
+ Misses      5469    5465     -4     
+ Partials    1542    1535     -7     
Impacted Files Coverage Δ
...lient/datascience/jupyter/liveshare/serverCache.ts 83% <ø> (ø)
src/client/datascience/jupyter/kernels/kernel.ts 75% <100%> (ø)
src/client/datascience/utils.ts 47% <100%> (ø)
...ence/notebook/intellisense/intellisenseProvider.ts 79% <0%> (-1%) ⬇️
src/client/common/types.ts 100% <0%> (ø)
src/client/debugger/jupyter/kernelDebugAdapter.ts 77% <0%> (+<1%) ⬆️
...lient/datascience/jupyter/kernels/cellExecution.ts 77% <0%> (+<1%) ⬆️
...t/datascience/notebook/vscodeNotebookController.ts 80% <0%> (+<1%) ⬆️
src/client/extensionActivation.ts 97% <0%> (+1%) ⬆️
...atascience/interactive-window/interactiveWindow.ts 69% <0%> (+1%) ⬆️
... and 4 more

@IanMatthewHuff IanMatthewHuff merged commit 1a4539c into main Jan 13, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/multiRootIssues branch January 13, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants