Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'experimental' tags to package.json for pylance experiment #8687

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jan 13, 2022

@rchiodo rchiodo requested a review from a team as a code owner January 13, 2022 17:59
@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 13, 2022

Still need to force enable this in the preview version of the extension.

@IanMatthewHuff
Copy link
Member

IanMatthewHuff commented Jan 13, 2022

Something odd going on with the checks on this?

Edit: NVMD, same thing happening with my PR. Looking now.

@codecov-commenter
Copy link

Codecov Report

Merging #8687 (7861425) into main (c60dcfd) will increase coverage by 0%.
The diff coverage is 85%.

❗ Current head 7861425 differs from pull request most recent head 5bf608f. Consider uploading reports for the commit 5bf608f to get more accurate results

@@          Coverage Diff          @@
##            main   #8687   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        384     384           
  Lines      24666   24670    +4     
  Branches    3794    3796    +2     
=====================================
+ Hits       17655   17662    +7     
+ Misses      5469    5466    -3     
  Partials    1542    1542           
Impacted Files Coverage Δ
src/client/extensionActivation.ts 94% <50%> (-2%) ⬇️
src/client/common/types.ts 100% <100%> (ø)
...ence/notebook/intellisense/intellisenseProvider.ts 80% <100%> (+<1%) ⬆️
...ience/variablesView/variableViewMessageListener.ts 77% <0%> (-23%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 67% <0%> (-11%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 67% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 77% <0%> (+<1%) ⬆️
src/client/datascience/raw-kernel/rawSocket.ts 84% <0%> (+1%) ⬆️
src/client/datascience/dataScienceSurveyBanner.ts 75% <0%> (+6%) ⬆️

@rchiodo rchiodo merged commit 13deddf into main Jan 13, 2022
@rchiodo rchiodo deleted the add-experimental-tag branch January 13, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants