Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme to remove insiders specific references + some cleanup #8764

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

IanMatthewHuff
Copy link
Member

For #8548

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).


- **Step 2** If not working with Python, make sure to have a Jupyter kernelspec that corresponds to the language you would like to use installed on your machine.

- **Step 3.** Install the [Jupyter Extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter)

- **Step 4.** Open or create a notebook file and start coding!
- **Step 4.** Open or create a notebook file and start coding.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed basically all !s out of a strong personal preference ;). However I'm totally willing to put them back in if I'm outvoted here.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review January 21, 2022 17:36
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner January 21, 2022 17:36
Copy link
Member

@greazer greazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Ian!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!... !!!!!!!! ! ! !

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #8764 (8e688e7) into main (8b707fe) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #8764   +/-   ##
=====================================
  Coverage     71%     72%           
=====================================
  Files        381     381           
  Lines      24535   24535           
  Branches    3772    3772           
=====================================
+ Hits       17640   17708   +68     
+ Misses      5379    5295   -84     
- Partials    1516    1532   +16     
Impacted Files Coverage Δ
...tascience/jupyter/kernels/kernelCommandListener.ts 70% <0%> (-4%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 67% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 59% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernels/helpers.ts 72% <0%> (-2%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 80% <0%> (-1%) ⬇️
src/client/datascience/dataScienceSurveyBanner.ts 75% <0%> (ø)
src/client/datascience/commands/commandRegistry.ts 40% <0%> (+<1%) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 75% <0%> (+<1%) ⬆️
src/client/datascience/baseJupyterSession.ts 76% <0%> (+<1%) ⬆️
src/client/datascience/jupyterDebugService.ts 17% <0%> (+1%) ⬆️
... and 25 more

@IanMatthewHuff IanMatthewHuff merged commit c2bbbaa into main Jan 21, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/readmeUpdate branch January 21, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants