add TextDocument tests for invalid inputs #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
previously approved these changes
Jul 9, 2024
|
@dbaeumer For you to review... |
dbaeumer
approved these changes
Jul 30, 2024
TylerLeonhardt
approved these changes
Jul 30, 2024
|
I'm not sure if this repo follows semver or not, but just a heads up that this PR (being released as 1.0.12 of Probably that we were relying on broken behaviour, but still, lost a few hours tracking this PR, not helped by the title being "add tests" when it in fact, does not just add tests 😅 |
|
@Princesseuh sorry for the bad title. We do use semver but since this is a bug fix for a broken behavior (#1285) it is not a major version update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds more tests for
TextDocumentdealing with positions/offsets around line endings.Ref #1285