-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TextDocument tests for invalid inputs #1286
Conversation
@dbaeumer For you to review... |
I'm not sure if this repo follows semver or not, but just a heads up that this PR (being released as 1.0.12 of Probably that we were relying on broken behaviour, but still, lost a few hours tracking this PR, not helped by the title being "add tests" when it in fact, does not just add tests 😅 |
@Princesseuh sorry for the bad title. We do use semver but since this is a bug fix for a broken behavior (#1285) it is not a major version update. |
adds more tests for
TextDocument
dealing with positions/offsets around line endings.Ref #1285