Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProtocolConverter#asWorkspaceEdit to correctly support workspace edits with snippets #1424

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

dbaeumer
Copy link
Member

@dbaeumer dbaeumer commented Feb 9, 2024

This pull request fixes the issue #1414 by updating the ProtocolConverter#asWorkspaceEdit method to correctly support workspace edits with snippets. The changes include updating the VS Code version to 1.86, adjusting the package.json file, and modifying the code in the protocol converter to construct VS Code text edits for SnippetTextEdit. The converted edits are maintained in an array and then set using the result.set method.

@dbaeumer dbaeumer merged commit 3555a32 into main Feb 9, 2024
6 checks passed
@dbaeumer dbaeumer deleted the dbaeumer/gross-falcon-amethyst branch February 9, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants