Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Inlay Hints #609

Closed
wants to merge 1 commit into from
Closed

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Apr 7, 2020

This is the start of an "inlay hints" feature proposal. It is essentially the interface we use in rust-analyzer to achieve inlay hints (microsoft/vscode#16221)

I am working on this in my spare time (hence just the md for now) but would like to get feedback.

@msftclas
Copy link

msftclas commented Apr 7, 2020

CLA assistant check
All CLA requirements met.

@rcjsuen
Copy link
Contributor

rcjsuen commented Apr 7, 2020

I am working on this in my spare time (hence just the md for now) but would like to get feedback.

@kjeremy I suggest you share your proposal as an issue in the microsoft/language-server-protocol repository.

@dbaeumer
Copy link
Member

dbaeumer commented Apr 8, 2020

@jrieken and @mjbvz has something like this every come up in the VS Code API. I actually do like the feature especially for inferred types.

@kjeremy
Copy link
Contributor Author

kjeremy commented Apr 8, 2020

A screen shot of this in action can be found at microsoft/vscode#16221 (comment)

@jrieken
Copy link
Member

jrieken commented Apr 8, 2020

https://marketplace.visualstudio.com/items?itemName=sokra.ts-inline-types 👈 an extension that does this for TypeScript - tho, by creating yet another instance of the compiler

@KamasamaK
Copy link

@mjbvz I see that you locked microsoft/vscode#16221. I agree that the nature of the comments mostly amounted to noise, but locking also prevents further actual +1s on the opening post.

@mjbvz
Copy link
Contributor

mjbvz commented Apr 8, 2020

We are still tracking it. There were enough +1 and comments on the issue to know that it’s something users are interested in

@matklad
Copy link
Contributor

matklad commented Apr 8, 2020

Something which I believe is missing form discussion so far is that one could (but not necessary should) go beyond plain text for hints:

image

@Veetaha
Copy link

Veetaha commented Apr 8, 2020

Maybe we should move the discussion to microsoft/language-server-protocol#956?

@dbaeumer
Copy link
Member

dbaeumer commented Jun 3, 2021

Lets close this in favour of #772

@dbaeumer dbaeumer closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants