Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debugEditorContents and runEditorContents command examples #43

Closed
gjsjohnmurray opened this issue Jun 25, 2020 · 3 comments
Closed

Improve debugEditorContents and runEditorContents command examples #43

gjsjohnmurray opened this issue Jun 25, 2020 · 3 comments
Assignees
@weinand
Labels
enhancement
Milestone
November 2020

Comments

@gjsjohnmurray
Copy link

Proposed improvements to the features recently added in support of microsoft/vscode#92269

  • Prefix the commands with Mock Debug:
  • Hide the commands from the Command Palette
  • Disable the commands when in debug mode, otherwise the editor command buttons remain active and could be mistaken for ways to interact with the debugging just launched. If they remain active and are clicked the user ends up with multiple concurrent debug sessions, which could be another source of confusion.

I will submit a PR shortly.
gjsjohnmurray added a commit to gjsjohnmurray/vscode-mock-debug that referenced this issue Jun 25, 2020
@gjsjohnmurray
fix microsoft#43 Smarter handling of run and debug commands
4969847
@gjsjohnmurray gjsjohnmurray mentioned this issue Jun 25, 2020
Closed
gjsjohnmurray added a commit to gjsjohnmurray/vscode-mock-debug that referenced this issue Jun 26, 2020
@gjsjohnmurray
Merge branch 'master' into fix-microsoft#43
0f1b27f
@gjsjohnmurray
Copy link
Author

@isidorn @weinand my PR #44 is ready for review. Its purpose is to make Mock Debug an even better model for the recommendations stated at microsoft/vscode#92269 (comment). In particular it uses enablement to deactivate the command buttons when debug is in progress. See above for my reasoning.

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2020

@gjsjohnmurray thanks a lot for looking into this! I will comment in the PR

gjsjohnmurray added a commit to gjsjohnmurray/vscode-mock-debug that referenced this issue Jun 26, 2020
@gjsjohnmurray
Merge branch 'fix-microsoft#43' of https://github.com/gjsjohnmurray/v…
467b40e 
…scode-mock-debug into fix-microsoft#43
weinand added a commit that referenced this issue Nov 6, 2020
@weinand
Merge branch 'gjsjohnmurray-fix-#43'
ae85025
@weinand
Copy link
Contributor

weinand commented Nov 6, 2020

I've merged the PR

@weinand weinand closed this as completed Nov 6, 2020
@weinand weinand added this to the November 2020 milestone Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weinand weinand

Labels
enhancement
Projects
None yet
Milestone
November 2020
Development

Successfully merging a pull request may close this issue.

fix #43 Smarter handling of run and debug commands gjsjohnmurray/vscode-mock-debug
3 participants
@weinand @isidorn @gjsjohnmurray