Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typings for azdataGraph lib #18459

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fixing typings for azdataGraph lib #18459

merged 1 commit into from
Dec 2, 2024
+5 −11

Conversation

aasimkhan30
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 49.72% 49.86% $${\color{lightgreen} .14\% }$$
VSIX Size 11714 KB 11714 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3108 KB 3108 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

Benjin
Benjin reviewed Dec 2, 2024
View reviewed changes
typings/azdataGraph.d.ts
@@ -1,6 +0,0 @@
declare module 'azdataGraph/dist/build' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checking: this was intentionally removed, and doesn't need to be replaced?

Copy link
Contributor Author

@aasimkhan30 aasimkhan30 Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, now the library includes this module declaration and the consumers don't have to define their own module

@aasimkhan30 aasimkhan30 merged commit 935e20d into main Dec 2, 2024
6 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/azdataGraphTypings branch December 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjin Benjin Benjin approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@cssuh cssuh Awaiting requested review from cssuh cssuh is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasimkhan30 @Benjin