Tests: Output Content Provider query related functionality #626
Conversation
|
Hi @Raymondd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
…tests/outputContentProvider
| @@ -0,0 +1,76 @@ | |||
| // TODO: rewrite all the outputprovider handle tests (old ones kept for reference) | |||
There was a problem hiding this comment.
I'd remove this test class if it's no longer relevant. People can go back in Git history if they need to retrieve at all. Unless there's a reason to preserve?
|
|
||
| // Check if the results window already exists | ||
| // Intentionally created anonymously for testing purposes | ||
| public displayResultPane = function(resultsUri: string, paneTitle: string): void { |
There was a problem hiding this comment.
This is kinda goofy. I think using TypeMoq you can just mock a real instance of this class and override this one function, avoiding the need to add in a setDisplayResultPane and declare this anonymously. However it's not critical to fix.
There was a problem hiding this comment.
I couldn't do a partial Moq, but I did fix this goofy syntax in the class.
Addresses #584.
The request handler tests seem like they may need to be refactored to be properly testable. I created Issue #625 to track these changed since they are going to be significantly different from these query related tests.