-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Keybindings not working #3190
Comments
In general, if a command is hidden from the command palette and the command is not specifically listed in documentation as being available from everywhere, then it may behave poorly when used in a keybinding. |
Thanks for the clarification. The Regarding the Or is it not this you mean with
|
For |
To verify:
|
For microsoft/vscode#164641, when I go into review mode and use the keybind on the |
Issue Type: Bug
I'm trying out the keybindings provided by the extension but it's not working.
I have tried
GitHub Pull Requests: Copy Commit Hash
which gives the error:Cannot read property 'sha' of undefined
when used.And also
GitHub Pull Requests: Mark File As Viewed
which gives the error:Marked file as viewed failed: TypeError: Cannot read property 'pullRequest' of undefined
Nor sure if I'm doing anything wrong here but shouldn't it just work after being assinge a key combination?
Extension version: 0.34.0
VS Code version: Code 1.63.0 (7db1a2b88f7557e0a43fec75b6ba7e50b3e9f77e, 2021-12-07T06:26:56.179Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Remote OS version: Linux x64 5.10.60.1-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.60.1-microsoft-standard-WSL2
System Info
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: