Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically collapse comments once they are resolved #5031

Closed
joyceerhl opened this issue Jul 10, 2023 · 4 comments · Fixed by microsoft/vscode#192864
Closed

Automatically collapse comments once they are resolved #5031

joyceerhl opened this issue Jul 10, 2023 · 4 comments · Fixed by microsoft/vscode#192864
Assignees
@alexr00
Labels
feature-request Request for new features or functionality upstream/vscode verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2023

Comments

@joyceerhl
Copy link
Contributor

  1. Have an unresolved comment on a pull request that is open in VS Code
  2. Click 'Resolve Conversation'
  3. Comment remains open, I still have to manually click collapse

I'd expect that resolving a comment also collapses the comment so that it no longer takes up space, which is what happens on github.com
@alexr00 alexr00 added the feature-request Request for new features or functionality label Jul 11, 2023
@alexr00 alexr00 added this to the August 2023 milestone Jul 11, 2023
@alexr00 alexr00 modified the milestones: August 2023, On Deck Aug 16, 2023
@alexr00
Copy link
Member

alexr00 commented Aug 16, 2023

This is going to need VS Code API to enable collapsing a comment. Just like the tree view, the comment thread collapsible state cannot be modified by the extension once set to prevent conflict between user state and extension state.

@alexr00 alexr00 mentioned this issue Aug 28, 2023
Closed
@brettcannon brettcannon mentioned this issue Aug 29, 2023
Closed
@alexr00 alexr00 modified the milestones: On Deck, September 2023 Aug 29, 2023
@alexr00 alexr00 mentioned this issue Sep 12, 2023
Merged
alexr00 added a commit to microsoft/vscode that referenced this issue Sep 12, 2023
@alexr00
Add a setting to collapse comments on resolve
c68b337 
Fixes microsoft/vscode-pull-request-github#5031
@alexr00
Copy link
Member

alexr00 commented Sep 12, 2023

The setting to control this is comments.collapseOnResolve. It is true by default.

@kieferrm kieferrm mentioned this issue Sep 12, 2023
Closed
62 tasks
alexr00 added a commit to microsoft/vscode that referenced this issue Sep 13, 2023
@alexr00
Add a setting to collapse comments on resolve (#192864)
f36df69 
Fixes microsoft/vscode-pull-request-github#5031
lins0621 pushed a commit to lins0621/vscode that referenced this issue Sep 14, 2023
@alexr00 @lins0621
Add a setting to collapse comments on resolve (microsoft#192864)
d7b112e 
Fixes microsoft/vscode-pull-request-github#5031
@alexr00
Copy link
Member

alexr00 commented Sep 25, 2023

To verify:

  1. Install GitHub Pull Requests and Issues
  2. Open a PR file and leave a comment
  3. Resolve the comment
  4. Verify that the comment immediately closes
  5. Unresolve the comment
  6. Set "comments.collapseOnResolve": false
  7. Resolve the comment again
  8. Verify that the comment is not closed.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Sep 25, 2023
@meganrogge meganrogge added the verified Verification succeeded label Sep 26, 2023
@meganrogge
Copy link
Contributor

🎉 works well! such a great feature, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality upstream/vscode verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Add a setting to collapse comments on resolve microsoft/vscode
3 participants
@meganrogge @joyceerhl @alexr00