Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve outdated comments experience #5760

Closed
alexr00 opened this issue Feb 16, 2024 · 2 comments · Fixed by #5818
Closed

Improve outdated comments experience #5760

alexr00 opened this issue Feb 16, 2024 · 2 comments · Fixed by #5818
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 16, 2024

Discussing with @hediet and we found some things that could significantly improve outdated comments:

  • Add some indicator in the comment widget that the comment is outdated
  • When clicking on the comment, don't just open the outdated file with the comment, instead open the a diff with the outdated file on the left and the head on the right.
@alexr00 alexr00 added the feature-request Request for new features or functionality label Feb 16, 2024
@alexr00 alexr00 added this to the March 2024 milestone Feb 16, 2024
@alexr00 alexr00 self-assigned this Feb 16, 2024
@alexr00
Copy link
Member Author

alexr00 commented Mar 5, 2024

Example of what we have now:

Image

@alexr00
Copy link
Member Author

alexr00 commented Mar 8, 2024

I don't see a nice way to enable clicking on the comment thread to open a diff. Currently, clicking on the comment thread opens the resource that the comment applies to. I don't want to open this up to arbitrary commands.

I've added an inline action to diff the comment with the head. I'm hoping that this will also function as an indicator that it's an outdated comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant