Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension should still work if only upstream requires SAML #6159

Closed
alexr00 opened this issue Aug 26, 2024 · 1 comment · Fixed by #6414
Closed

Extension should still work if only upstream requires SAML #6159

alexr00 opened this issue Aug 26, 2024 · 1 comment · Fixed by #6414
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2024

Comments

@alexr00
Copy link
Member

alexr00 commented Aug 26, 2024

Example:

  1. Fork https://github.com/AzureAD/microsoft-authentication-library-for-js
  2. Create a Codespace for your fork
  3. When prompted for SAML for AzureAD, don't provide it
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2024
@alexr00 alexr00 added this to the September 2024 milestone Aug 26, 2024
@alexr00 alexr00 self-assigned this Aug 26, 2024
@alexr00 alexr00 modified the milestones: September 2024, October 2024 Sep 23, 2024
alexr00 added a commit that referenced this issue Oct 24, 2024
@alexr00
Extension should still work if only upstream requires SAML
e7c58a3 
Fixes #6159
@alexr00 alexr00 mentioned this issue Oct 24, 2024
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Extension should still work if only upstream requires SAML microsoft/vscode-pull-request-github
3 participants
@rzhao271 @alexr00 and others