Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 icon is confusing to me here #6289

Closed
bpasero opened this issue Oct 16, 2024 · 5 comments · Fixed by #6299
Closed

🎁 icon is confusing to me here #6289

bpasero opened this issue Oct 16, 2024 · 5 comments · Fixed by #6299
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2024

Comments

@bpasero
Copy link
Member

bpasero commented Oct 16, 2024

Image

The meaning of what this action would do is not clear to me until I hover. If this is associated with Copilot Chat, then I would suggest to use the ✨ icon as we do in other places.
@alexr00
Copy link
Member

alexr00 commented Oct 16, 2024

It isn't associated with Copilot, it's for converting all your git changes into GitHub comment's with suggested changes, no AI required. Related: https://github.com/microsoft/vscode-copilot/issues/9203#issuecomment-2415303332

I would love to have different icon for this, but I don't know of an icon that makes sense.

@alexr00 alexr00 added under-discussion Issue is under discussion for relevance, priority, approach *duplicate Issue identified as a duplicate of another issue(s) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Oct 16, 2024
@alexr00
Copy link
Member

alexr00 commented Oct 16, 2024

Maybe just the comment icon?

@alexr00 alexr00 added this to the October 2024 milestone Oct 16, 2024
@bpasero
Copy link
Member Author

bpasero commented Oct 16, 2024

@alexr00 oh I see! yes now it makes more sense to me, so something that looks like associating with comments would be great, maybe a combination of comments and a "plus" sign?

//cc @daviddossett

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 17, 2024
alexr00 added a commit that referenced this issue Oct 17, 2024
@alexr00
🎁 icon is confusing to me here
1a1fbb7 
Fixes #6289
@alexr00 alexr00 mentioned this issue Oct 17, 2024
Merged
@bpasero
Copy link
Member Author

bpasero commented Oct 22, 2024

@alexr00 now I struggle how to make this icon appear in a fresh insiders 🤔

Image

@alexr00
Copy link
Member

alexr00 commented Oct 22, 2024 •
edited
Loading

@bpasero I still see it. Here are the conditions under which it will show:

  • You have a PR checked out
  • At least one of the files that have changes is in the PR

Image

@bpasero bpasero added the verified Verification succeeded label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

🎁 icon is confusing to me here microsoft/vscode-pull-request-github
2 participants
@bpasero @alexr00