Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty array to be pushed to remove the last label #4648

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Allow empty array to be pushed to remove the last label #4648

merged 1 commit into from
Mar 21, 2023

Conversation

Balastrong
Copy link
Contributor

Pretty much the same as #4637 but in the PR description view.

Here is less debilitating though, because labels have the X button anyway (which already works fine)

image

@Balastrong Balastrong mentioned this pull request Mar 20, 2023
Merged
alexr00
alexr00 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@alexr00 alexr00 added this to the March 2023 milestone Mar 21, 2023
@alexr00 alexr00 enabled auto-merge (squash) March 21, 2023 09:41
@alexr00 alexr00 merged commit 14c4bcf into microsoft:main Mar 21, 2023
@Balastrong Balastrong deleted the fix/remove-last-pr-label branch March 21, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandy081 sandy081 sandy081 approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@Balastrong @sandy081 @alexr00