Skip to content

Commit

Permalink
Add a new measure for native finder perf (#23861)
Browse files Browse the repository at this point in the history
  • Loading branch information
DonJayamanne authored Jul 23, 2024
1 parent 1f12640 commit 30058f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export function sendNativeTelemetry(
refreshTelemetrySent = true;
sendTelemetryEvent(EventName.NATIVE_FINDER_PERF, {
duration: data.data.refreshPerformance.total,
totalDuration: data.data.refreshPerformance.total,
breakdownGlobalVirtualEnvs: data.data.refreshPerformance.breakdown.GlobalVirtualEnvs,
breakdownLocators: data.data.refreshPerformance.breakdown.Locators,
breakdownPath: data.data.refreshPerformance.breakdown.Path,
Expand Down
3 changes: 2 additions & 1 deletion src/client/telemetry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1738,6 +1738,7 @@ export interface IEventNamePropertyMapping {
/* __GDPR__
"native_finder_perf" : {
"duration" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "donjayamanne" },
"totalDuration" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "donjayamanne" },
"breakdownLocators" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "donjayamanne" },
"breakdownPath" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "donjayamanne" },
"breakdownGlobalVirtualEnvs" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "donjayamanne" },
Expand Down Expand Up @@ -1767,7 +1768,7 @@ export interface IEventNamePropertyMapping {
* This is the time from the perspective of the Native Locator.
* I.e. starting from the time the request to refresh was received until the end of the refresh.
*/
duration: number;
totalDuration: number;
/**
* Time taken by all locators to find the environments.
* I.e. time for Conda + Poetry + Pyenv, etc (note: all of them run in parallel).
Expand Down

0 comments on commit 30058f2

Please sign in to comment.