Remove Interpereter version service

microsoft · Oct 20, 2021 · 5007d03 · 5007d03
1 parent 1789823
commit 5007d03
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 127 deletions.
diff --git a/src/client/interpreter/contracts.ts b/src/client/interpreter/contracts.ts
@@ -7,11 +7,6 @@ import { PythonLocatorQuery } from '../pythonEnvironments/base/locator';
 import { CondaEnvironmentInfo } from '../pythonEnvironments/common/environmentManagers/conda';
 import { EnvironmentType, PythonEnvironment } from '../pythonEnvironments/info';
 
-export const IInterpreterVersionService = Symbol('IInterpreterVersionService');
-export interface IInterpreterVersionService {
-    getVersion(pythonPath: string, defaultValue: string): Promise<string>;
-}
-
 export type PythonEnvironmentsChangedEvent = {
     type?: FileChangeType;
     resource?: Uri;

diff --git a/src/client/interpreter/interpreterVersion.ts b/src/client/interpreter/interpreterVersion.ts
diff --git a/src/client/interpreter/serviceRegistry.ts b/src/client/interpreter/serviceRegistry.ts
@@ -23,19 +23,12 @@ import {
     IPythonPathUpdaterServiceFactory,
     IPythonPathUpdaterServiceManager,
 } from './configuration/types';
-import {
-    IInterpreterDisplay,
-    IInterpreterHelper,
-    IInterpreterService,
-    IInterpreterVersionService,
-    IShebangCodeLensProvider,
-} from './contracts';
+import { IInterpreterDisplay, IInterpreterHelper, IInterpreterService, IShebangCodeLensProvider } from './contracts';
 import { InterpreterDisplay } from './display';
 import { InterpreterLocatorProgressStatubarHandler } from './display/progressDisplay';
 import { ShebangCodeLensProvider } from './display/shebangCodeLensProvider';
 import { InterpreterHelper } from './helpers';
 import { InterpreterService } from './interpreterService';
-import { InterpreterVersionService } from './interpreterVersion';
 import { CondaInheritEnvPrompt } from './virtualEnvs/condaInheritEnvPrompt';
 import { VirtualEnvironmentPrompt } from './virtualEnvs/virtualEnvPrompt';
 
@@ -62,8 +55,6 @@ export function registerInterpreterTypes(serviceManager: IServiceManager): void
 
     serviceManager.addSingleton<IExtensionActivationService>(IExtensionActivationService, VirtualEnvironmentPrompt);
 
-    serviceManager.addSingleton<IInterpreterVersionService>(IInterpreterVersionService, InterpreterVersionService);
-
     serviceManager.addSingleton<IInterpreterService>(IInterpreterService, InterpreterService);
     serviceManager.addSingleton<IInterpreterDisplay>(IInterpreterDisplay, InterpreterDisplay);
 

diff --git a/src/test/common/process/execFactory.test.ts b/src/test/common/process/execFactory.test.ts
diff --git a/src/test/interpreters/serviceRegistry.unit.test.ts b/src/test/interpreters/serviceRegistry.unit.test.ts
@@ -30,15 +30,13 @@ import {
     IInterpreterDisplay,
     IInterpreterHelper,
     IInterpreterService,
-    IInterpreterVersionService,
     IShebangCodeLensProvider,
 } from '../../client/interpreter/contracts';
 import { InterpreterDisplay } from '../../client/interpreter/display';
 import { InterpreterLocatorProgressStatubarHandler } from '../../client/interpreter/display/progressDisplay';
 import { ShebangCodeLensProvider } from '../../client/interpreter/display/shebangCodeLensProvider';
 import { InterpreterHelper } from '../../client/interpreter/helpers';
 import { InterpreterService } from '../../client/interpreter/interpreterService';
-import { InterpreterVersionService } from '../../client/interpreter/interpreterVersion';
 import { registerTypes } from '../../client/interpreter/serviceRegistry';
 import { CondaInheritEnvPrompt } from '../../client/interpreter/virtualEnvs/condaInheritEnvPrompt';
 import { VirtualEnvironmentPrompt } from '../../client/interpreter/virtualEnvs/virtualEnvPrompt';
@@ -56,8 +54,6 @@ suite('Interpreters - Service Registry', () => {
 
             [IExtensionActivationService, VirtualEnvironmentPrompt],
 
-            [IInterpreterVersionService, InterpreterVersionService],
-
             [IInterpreterService, InterpreterService],
             [IInterpreterDisplay, InterpreterDisplay],