Skip to content

Commit

Permalink
Rename utils to pvsc_utils to prevent shadowing (#22760)
Browse files Browse the repository at this point in the history
Closes #22575
Closes #22757
  • Loading branch information
karthiknadig authored Jan 17, 2024
1 parent baea7a1 commit 6f0b841
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Licensed under the MIT License.

import os
from unittestadapter.utils import TestNodeTypeEnum
from unittestadapter.pvsc_utils import TestNodeTypeEnum
from .helpers import TEST_DATA_PATH
import pathlib

Expand Down
2 changes: 1 addition & 1 deletion pythonFiles/tests/unittestadapter/test_discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import pytest
from unittestadapter.discovery import discover_tests
from unittestadapter.utils import TestNodeTypeEnum, parse_unittest_args
from unittestadapter.pvsc_utils import TestNodeTypeEnum, parse_unittest_args

from . import expected_discovery_test_output
from .helpers import TEST_DATA_PATH, is_same_tree
Expand Down
2 changes: 1 addition & 1 deletion pythonFiles/tests/unittestadapter/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import pytest

from unittestadapter.utils import (
from unittestadapter.pvsc_utils import (
TestNode,
TestNodeTypeEnum,
build_test_tree,
Expand Down
6 changes: 5 additions & 1 deletion pythonFiles/unittestadapter/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
from typing_extensions import Literal, NotRequired, TypedDict

# If I use from utils then there will be an import error in test_discovery.py.
from unittestadapter.utils import TestNode, build_test_tree, parse_unittest_args
from unittestadapter.pvsc_utils import (
TestNode,
build_test_tree,
parse_unittest_args,
)

DEFAULT_PORT = 45454

Expand Down
2 changes: 1 addition & 1 deletion pythonFiles/unittestadapter/execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

from testing_tools import process_json_util, socket_manager
from typing_extensions import Literal, NotRequired, TypeAlias, TypedDict
from unittestadapter.utils import parse_unittest_args
from unittestadapter.pvsc_utils import parse_unittest_args

ErrorType = Union[
Tuple[Type[BaseException], BaseException, TracebackType], Tuple[None, None, None]
Expand Down
File renamed without changes.

0 comments on commit 6f0b841

Please sign in to comment.