Skip to content

Commit

Permalink
Cherry pick fix for native notebook support into release branch (#15369)
Browse files Browse the repository at this point in the history
* Fix problem with notebook apis not being used. (#15366)

* Update changelog

* Remove news file
  • Loading branch information
rchiodo authored Feb 9, 2021
1 parent 84a7c15 commit 7352a0a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
([#15232](https://github.com/Microsoft/vscode-python/issues/15232))
1. Ensure target environment is activated in the terminal when running install scripts.
([#15285](https://github.com/Microsoft/vscode-python/issues/15285))
1. Allow support for using notebook APIs in the VS code stable build.
([#15364](https://github.com/Microsoft/vscode-python/issues/15364))

### Code Health

Expand Down
2 changes: 1 addition & 1 deletion src/client/common/application/notebook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class VSCodeNotebook implements IVSCodeNotebook {
@inject(IDisposableRegistry) private readonly disposables: IDisposableRegistry,
@inject(IApplicationEnvironment) readonly env: IApplicationEnvironment,
) {
if (this.useProposedApi && this.env.channel === 'insiders') {
if (this.useProposedApi) {
this.addEventHandlers();
this.canUseNotebookApi = true;
}
Expand Down

0 comments on commit 7352a0a

Please sign in to comment.