Skip to content

Commit

Permalink
Rename telemetry variable name to match constant value (#15615)
Browse files Browse the repository at this point in the history
  • Loading branch information
joyceerhl authored Mar 10, 2021
1 parent 532e0ba commit f04e60f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/client/telemetry/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export enum EventName {
TENSORBOARD_INSTALL_PROMPT_SHOWN = 'TENSORBOARD.INSTALL_PROMPT_SHOWN',
TENSORBOARD_INSTALL_PROMPT_SELECTION = 'TENSORBOARD.INSTALL_PROMPT_SELECTION',
TENSORBOARD_DETECTED_IN_INTEGRATED_TERMINAL = 'TENSORBOARD_DETECTED_IN_INTEGRATED_TERMINAL',
TENSORBOARD_INSTALL_SESSION_DEPENDENCIES_RESULT = 'TENSORBOARD.PACKAGE_INSTALL_RESULT',
TENSORBOARD_PACKAGE_INSTALL_RESULT = 'TENSORBOARD.PACKAGE_INSTALL_RESULT',
}

export enum PlatformErrors {
Expand Down
2 changes: 1 addition & 1 deletion src/client/telemetry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ export interface IEventNamePropertyMapping {
* Note, this is only sent if install was attempted. It is not sent if the user opted
* not to install, or if all dependencies were already installed.
*/
[EventName.TENSORBOARD_INSTALL_SESSION_DEPENDENCIES_RESULT]: {
[EventName.TENSORBOARD_PACKAGE_INSTALL_RESULT]: {
wasProfilerPluginAttempted: boolean;
wasTensorBoardAttempted: boolean;
wasProfilerPluginInstalled: boolean;
Expand Down
2 changes: 1 addition & 1 deletion src/client/tensorBoard/tensorBoardSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export class TensorBoardSession {
this.installer.isInstalled(Product.torchProfilerImportName, interpreter),
]);
// Send telemetry regarding results of install
sendTelemetryEvent(EventName.TENSORBOARD_INSTALL_SESSION_DEPENDENCIES_RESULT, undefined, {
sendTelemetryEvent(EventName.TENSORBOARD_PACKAGE_INSTALL_RESULT, undefined, {
wasTensorBoardAttempted: needsTensorBoardInstall,
wasProfilerPluginAttempted: needsProfilerPluginInstall,
wasTensorBoardInstalled: tensorboardInstallStatus === ProductInstallStatus.Installed,
Expand Down

0 comments on commit f04e60f

Please sign in to comment.