Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt to pre-release extension support #18144

Closed
isidorn opened this issue Dec 9, 2021 · 5 comments · Fixed by #18535
Closed

Adopt to pre-release extension support #18144

isidorn opened this issue Dec 9, 2021 · 5 comments · Fixed by #18535
Assignees
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone

Comments

@isidorn
Copy link

isidorn commented Dec 9, 2021

Refs: microsoft/vscode#15756

VS Code now supports pre-release extensions. Docs that should help: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

I know Python uses the setting to move users to an insiders version.
This is a bit of a special case since you do not have a separate extension so we do not support migration here. However we suggest that Python does the following for users that have this settings set:

  • Show a modal dialog or notification to user where she can confirm the transition
  • Once user confirms, execute the command workbench.extensions.installExtension and pass { installPreReleaseVersion: true }
  • Deprecate the setting

Let me know what you think or if I can help somehow.

fyi @brettcannon @sandy081

@isidorn isidorn added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Dec 9, 2021
@brettcannon
Copy link
Member

Was going to track this in favour of #17196, but I'm going to reverse it and close it in favour of this one instead (i.e. this is already on our roadmap and planned for 😃).

@brettcannon brettcannon added area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Dec 9, 2021
@brettcannon brettcannon added this to the January 2022 milestone Dec 9, 2021
@isidorn
Copy link
Author

isidorn commented Dec 10, 2021

@brettcannon sorry, did not see that one! Thanks for merging them and thanks for working on this.

@luabud
Copy link
Member

luabud commented Dec 14, 2021

I think we will also need to update what we define as an insider user for experimentation (ExP) purposes

@tanhakabir
Copy link

Not sure if the pre-release is out yet but I'm still seeing these notifications on any workspace that I have .py or .ipynb files in:
image

@karrtikr
Copy link

It's not out yet so this is expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants