Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a nightly/insiders extension in the Marketplace #17196

Closed
8 tasks
brettcannon opened this issue Sep 1, 2021 · 4 comments
Closed
8 tasks

Create a nightly/insiders extension in the Marketplace #17196

brettcannon opened this issue Sep 1, 2021 · 4 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. meta Issue that is tracking an overall project

Comments

@brettcannon
Copy link
Member

brettcannon commented Sep 1, 2021

This would replace our bespoke insiders channel download/install mechanism so we can rely on VS Code to update.

  • Create a package.prod.json which contains only that which would differ from the nightly build
  • Create a "nightly build" workflow (w/ uploading turned off)
  • Use GitHub Environments to control whether a nightly build gets pushed to the Marketplace
  • Create a custom build for blob storage that will notify people on our old insiders builds to switch to the new extension
  • Remove code for blob storage solution
  • Switch over to the new workflow
  • Upload the custom VSIX to blob storage
  • Make a stable release which would overwrite anyone on the insiders build from blob storage

#17133

@brettcannon brettcannon added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. meta Issue that is tracking an overall project planned 📅 labels Sep 1, 2021
@brettcannon brettcannon self-assigned this Sep 1, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 1, 2021
@brettcannon brettcannon removed the triage-needed Needs assignment to the proper sub-team label Sep 1, 2021
@brettcannon brettcannon added this to the September 2021 milestone Sep 1, 2021
@brettcannon
Copy link
Member Author

microsoft/vscode#15756 may lead to this being put on hold.

@jakebailey
Copy link
Member

A wrench in this plan is that Pylance hard depends on the core extension, as it's not the one running the server and such; if there are two Python extensions, we'd necessarily have to drop our side of the dependency and then figure out what to do with people who discover and install the stack via the Pylance extension.

@brettcannon
Copy link
Member Author

@jakebailey chances are we will probably go with the solution the VS Code core team is proposing and using the mechanism where there's just the single extension and VS Code controls which VSIX to download, but good point about how this might make it messy unless you also publish an insiders extension that relies on our insiders extension.

@brettcannon
Copy link
Member Author

Closing in favour of #18144

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. meta Issue that is tracking an overall project
Projects
None yet
Development

No branches or pull requests

2 participants