-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Discovery failing #24656
Comments
If you don't have more than 30 tests in your workspace, are you even testing 🤪. Merry Christmas, Happy Holidays, thanks for all you do, we'll survive till you fix it. The way to downgrade: on the Extension page, click the drop down arrow on the Uninstall Button and you can "Install Specific Version...". Also make sure Auto Update is switched off or it will bounce you straight back to the broken one. |
Just ran into this bug this AM. Confirming that downgrading is the correct interim solution for this. |
The codebase that I encountered this with and reported in #24655 is pretty small, only 16 tests and (per cov) 258 total statements. Downgrading to |
I also had this issue with
|
Probably redundant since it's been identified as a buffer overflow issue, but the specific place it hangs in the plugin is line 943 in request = f"""content-length: {len(data)}\ncontent-type: application/json\n\n{data}"""
__writer.write(request) # HANGS HERE 😞
__writer.flush() This may be a repeat bug? I've had discovery suddenly start hanging like this in the past, but didn't suspect an update, and never got to track it this far. It may be worth a warning in the code on the other end, and a test case. |
Maybe one symptom of a larger problem? I'm seeing similar hangs elsewhere:
Source Control involves a large number of pending changes. |
Any chance for a fix here soon? |
Details
|
I can confirm that |
Can confirm this works as well. |
Same issue, downgrading to v2024.22.0 fixed it for me |
fixes regression in #24656 by reverting problem
fixes regression in microsoft#24656 by reverting problem
revert the revert of the old commit so now main uses fifo again add a limit of 4096 bytes per communication sent between python subprocess and extension fixes #24656
Hello everyone! I appreciate everyone in the comments helping one another and also for your patience during the holiday season! I have put in a fix for this bug and it is now out on the pre-release version of the vscode-python extension. If people are able to try it out and let me know if this newer version fixes the bug that would be extremely helpful! The version of the extension you need is |
Hi @eleanorjboyd, I've tested it with the pre-release version |
Confirmed fixed on MacOS VSCode with prerelease extension as above. Thanks @eleanorjboyd |
fixes regression in microsoft#24656 by reverting problem
fixes regression in microsoft#24656 by reverting problem
revert the revert of the old commit so now main uses fifo again add a limit of 4096 bytes per communication sent between python subprocess and extension fixes microsoft#24656
fixes #24656 this change: restores the reverted code which switches to using fifo fixes the bug for large workspaces with fifo for mac
|
As an update the point release 2024.22.2 is out and has this fix for those who are not on the pre-release. Thanks! |
@eleanorjboyd can confirm that this is fixed for me and fixes #24655 as well, thank you! |
Details: Currently test discovery will "hang" with version
2024.22.1
if you have >30 tests in your workspace due to a buffer overflow issue. This should only occur for Mac and Linux machines.Workaround: Downgrade your python extension version to
2024.20.*
.The text was updated successfully, but these errors were encountered: