-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support frequent out of band updates to the language server #2580
Comments
How will you know there is a new version? Right now the extension simply downloads from a static URL that has no version information in it. |
I am yet to discuss this with @MikhailArkhipov |
As long as Option 1 is reliable and not too difficult to implement then I'm for that, but option 2 is good enough if needed. |
@qubitron @MikhailArkhipov @brettcannon @Microsoft/pvsc-team /cc |
It would be good to provide ability to turn off updates. Some people may not like us pinging Microsoft servers. AFAIK C# (OmniSharp) does not provide the prompt, it just downloads new bits. |
What should this setting be named: |
Live share automatically downloads new versions, so no prompt needed, option to turn it off is a good idea, the proposed setting looks fine to me. |
I agree with Mikhail that we need a way to turn this off for those that don't want to send anything to Microsoft, no matter how innocuous a version check is. |
I.e. as support to download language server more frequently.
E.g. once a week.
@qubitron @MikhailArkhipov
Would downloading once a week work? It do we download Everytime we come across a new release.
Please note, new versions will only be downloaded when the extension is loaded.
Option 1 (does not block use)
When extension loads look kor a new version
If a new version exists, download and extract (in background)
Once completed prompt user to restart vscode to use the new version
Pros, user can continue using extension with older language server, intellisense, navigation, etc will work. I.e. faster loading of extension.
Option 2:
The text was updated successfully, but these errors were encountered: