Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't seem to honor Python settings #26

Closed
Agnpalm opened this issue Nov 10, 2017 · 0 comments · Fixed by #222
Closed

Doesn't seem to honor Python settings #26

Agnpalm opened this issue Nov 10, 2017 · 0 comments · Fixed by #222
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone
December 2017

Comments

@Agnpalm
Copy link

Agnpalm commented Nov 10, 2017

I have VS Code 1.18.0, Python extension 0.8.0, published by Microsoft.

I have the setting "python.linting.enabled": false,, but linting is still active.
image
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Nov 13, 2017
@DonJayamanne DonJayamanne mentioned this issue Nov 14, 2017
Merged
DonJayamanne added a commit that referenced this issue Nov 15, 2017
@DonJayamanne
Fixes #26 Do not run linters when linters are disabled (#222)
f23439b 
* Fix microsoft/vscode#37627 (#1368)

* check doc language and if linting is disabled
@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
DonJayamanne added a commit that referenced this issue Dec 14, 2017
@DonJayamanne
Merge branch 'master' of https://github.com/Microsoft/vscode-python
d470523 
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
December 2017
Development

Successfully merging a pull request may close this issue.

Fixes #26 Do not run linters when linters are disabled DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @Agnpalm