Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure file paths are not sent in telemetry when running unit tests #1197

Merged
merged 2 commits into from
Mar 26, 2018

Conversation

DonJayamanne
Copy link

Fixes #1180

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #1197 into master will decrease coverage by 0.11%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   71.95%   71.84%   -0.12%     
==========================================
  Files         260      260              
  Lines       11922    11919       -3     
  Branches     2116     2116              
==========================================
- Hits         8579     8563      -16     
- Misses       3219     3226       +7     
- Partials      124      130       +6
Impacted Files Coverage Δ
src/client/unittests/codeLenses/testFiles.ts 18.64% <100%> (ø) ⬆️
src/client/unittests/main.ts 50.75% <100%> (ø) ⬆️
src/client/unittests/display/picker.ts 21.33% <25%> (-0.53%) ⬇️
src/client/unittests/common/testUtils.ts 68.47% <66.66%> (-0.68%) ⬇️
src/client/debugger/PythonProcess.ts 45.41% <0%> (-3.34%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 51.64% <0%> (-1.32%) ⬇️
src/client/linters/lintingEngine.ts 90.35% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df761e...7365cf7. Read the comment docs.

@DonJayamanne DonJayamanne merged commit e2b9037 into microsoft:master Mar 26, 2018
@DonJayamanne DonJayamanne deleted the issue1180Telemetry branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full file path sent in telemetry (when running tests)
2 participants