-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Notebook Renderers with VS Code Notebooks (disabled) #11999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -344,7 +356,8 @@ | |||
"XCI_PYTHON_PATH": "<Python Path>" | |||
}, | |||
"outFiles": [ | |||
"${workspaceFolder}/out/**/*.js" | |||
"${workspaceFolder}/out/**/*.js", | |||
"!${workspaceFolder}/**/node_modules**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes due to new debugger in VS Code (we'll need this to ensure we ignore node_modules in the out folder). Else debugger is very slow to load, causing extension to take 5-8 minutes to activate.
interactiveWindow: ['babel-polyfill', `./src/datascience-ui/history-react/index.tsx`] | ||
}; | ||
function getEntry(bundle) { | ||
switch (bundle) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to named bundles instead of a boolean.
@@ -298,7 +320,13 @@ function buildConfiguration(isNotebook) { | |||
] | |||
} | |||
}; | |||
|
|||
if (bundle === 'renderers') { | |||
delete config.optimization; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No optimization for renderer scripts, they don't work at all.
Will be resolved when VS Code adds support for loading split bundles.
For #11999 When running unit tests we don't need to compile the webviews (no need to compile react, etc). Total time to compile code down from 6 minutes to 1 minute (i.e. 5 minutes faster CI to know whether tests passed/failed) Note the drop in compile times from ~7minutes to ~50s. (basically 6 minutes faster)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
For #10496
Unfortunately some stuff isn't working properly, however I'd like to get this reviewed. The fixes should be simple.