Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore other notebooks (avoid conflicts with non jupyter nbs) #12335

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Ignore other notebooks (avoid conflicts with non jupyter nbs) #12335

merged 1 commit into from
Jun 15, 2020

Conversation

DonJayamanne
Copy link

For #10496

  • Ensure we do not treat notebooks such as Github Issues NB as one of ours.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jun 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit b5332bc into microsoft:master Jun 15, 2020
@DonJayamanne DonJayamanne deleted the skipOtherNotebooks branch June 15, 2020 20:01
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@greazer greazer Awaiting requested review from greazer

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

@rchiodo rchiodo Awaiting requested review from rchiodo

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @IanMatthewHuff @DavidKutu