Register notebook with VSC only in Insiders #12681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
DavidKutu,
greazer,
joyceerhl,
rchiodo and
techwithtim
… fixVSCAPI * 'fixVSCAPI' of github.com:DonJayamanne/pythonVSCode: More checks
rchiodo
approved these changes
Jun 30, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496
If the API changes, and user is not using the VSC Notebooks or insiders, then swallow errors.
Do not register API against stable version of VSCode.
Also fixed a test.
Basically we need to ensure VSC works when using this API and not crash if the API changes.