-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of escaped string in tokenizer + PTVS launch hardening #1377
Conversation
class LanguageServerStartupErrorHandler implements ErrorHandler { | ||
constructor(private readonly deferred: Deferred<void>) { } | ||
public error(error: Error, message: Message, count: number): ErrorAction { | ||
this.deferred.reject(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.deferred.reject(error)
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
- Coverage 71.45% 71.14% -0.31%
==========================================
Files 269 269
Lines 12403 12416 +13
Branches 2199 2199
==========================================
- Hits 8862 8833 -29
- Misses 3411 3452 +41
- Partials 130 131 +1
Continue to review full report at Codecov.
|
Fixes #1364
Harden language sever launch
Match PTVS changes in microsoft/PTVS#4024
This pull request: