Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pygls for 2.7 too #13896

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Fix pygls for 2.7 too #13896

merged 1 commit into from
Sep 12, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Sep 11, 2020

Seems pygls doesn't work on 2.7 either. Force this dependency to be 3.6 or newer.

@rchiodo rchiodo added the no-changelog No news entry required label Sep 11, 2020
@rchiodo rchiodo self-assigned this Sep 11, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #13896 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13896      +/-   ##
==========================================
- Coverage   59.86%   59.84%   -0.03%     
==========================================
  Files         693      693              
  Lines       38355    38355              
  Branches     5516     5516              
==========================================
- Hits        22961    22952       -9     
- Misses      14214    14220       +6     
- Partials     1180     1183       +3     
Impacted Files Coverage Δ
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 60.00% <0.00%> (-8.00%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13cf31a...e03041c. Read the comment docs.

@rchiodo rchiodo merged commit 8da0b92 into main Sep 12, 2020
@rchiodo rchiodo deleted the rchiodo/more27_fixes branch September 12, 2020 00:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

joar added a commit to joar/vscode-python that referenced this pull request Nov 26, 2024
`ruff` 0.8.0 (released 2024-11-22) no longer defaults to supporting Python 3.8,

> Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Python version
> is configured using [`ruff.target-version`](https://docs.astral.sh/ruff/settings/#target-version)
> or [`project.requires-python`](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires)
> ([microsoft#13896](astral-sh/ruff#13896))
> — https://github.com/astral-sh/ruff/blob/f3dac27e9aa6ac6a20fc2fb27ff2e4f5d369b076/CHANGELOG.md#080

We want to support Python 3.8 until February 2025, so we need to set
`target-version`.

> The minimum Python version to target, e.g., when considering automatic code
> upgrades, like rewriting type annotations. Ruff will not propose changes
> using features that are not available in the given version.
> — https://docs.astral.sh/ruff/settings/#target-version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants