Replace prompt with quickpick #14885
Conversation
joyceerhl
requested review from
IanMatthewHuff,
DonJayamanne,
karthiknadig,
karrtikr,
jmew,
rchiodo,
DavidKutu and
kimadeline
Codecov Report
@@ Coverage Diff @@
## main #14885 +/- ##
======================================
Coverage 65% 65%
======================================
Files 551 551
Lines 25896 25901 +5
Branches 3673 3673
======================================
+ Hits 16905 16910 +5
Misses 8298 8298
Partials 693 693
|
| const selection = await window.showInformationMessage(message, ...prompts); | ||
| switch (selection) { | ||
| case gotIt: | ||
| const selectAnotherFolder = TensorBoard.selectAnotherFolder(); |
There was a problem hiding this comment.
Do we want a don't ask me again? I kept getting this prompt every time I opened a folder.
There was a problem hiding this comment.
So there are 2 prompts. The prompt you're thinking of is the 'VSCode now has native TensorBoard support' prompt, which does have a do not ask again option that permanently disables it. The other prompt (the one in this PR) is being removed in this PR because we decided users were going to miss it.
There was a problem hiding this comment.
This one:
vscode-python/src/client/tensorBoard/tensorBoardPrompt.ts
Lines 49 to 50 in d88c119
There was a problem hiding this comment.
Okay maybe it wasn't clear to me that I needed to disable the first prompt in order for the second one to stop appearing. I wanted to have the first prompt show up all the time (so that if I actually wanted to see the tensor board at some later date it would ask me again), but the second one kept asking me the same question over and over. I didn't want to have to answer the second question the same way more than once.
There was a problem hiding this comment.
Oh I see, yeah there wasn't a way to disable the the second prompt (the one about using the cwd for the log directory). But that prompt is being removed. And yes the first prompt is being changed to show up all the time now (with a do not show again button for when the user gets sick of seeing it)!
We do still need to ask the user for the log directory on each session launch, because we need to point tensorboard to the logfiles. Maybe we can add a workspace-level setting to 'Always use this log directory'? /cc @jmew
Addressing UX feedback from yesterday's PyTorch tooling sync. Change the logdir request flow to use a quickpick instead of a prompt, as it's likely that users will miss the prompt (which they must currently acknowledge before we proceed to start a session).
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).