Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorBoard session creation test #15091

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Add TensorBoard session creation test #15091

merged 4 commits into from
Jan 8, 2021

Conversation

joyceerhl
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #15091 (0b14c13) into main (f444948) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #15091   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        558      557    -1     
  Lines      26231    26220   -11     
  Branches    3728     3729    +1     
======================================
- Hits       17155    17061   -94     
- Misses      8381     8463   +82     
- Partials     695      696    +1     
Impacted Files Coverage Δ
...nments/discovery/locators/services/pyenvLocator.ts 63% <0%> (-31%) ⬇️
src/client/common/utils/text.ts 50% <0%> (-19%) ⬇️
...rc/client/pythonEnvironments/common/commonUtils.ts 77% <0%> (-12%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 64% <0%> (-10%) ⬇️
src/client/interpreter/activation/service.ts 76% <0%> (-3%) ⬇️
src/client/common/utils/exec.ts 20% <0%> (-2%) ⬇️
src/client/pythonEnvironments/base/envsCache.ts 68% <0%> (-2%) ⬇️
...s/discovery/locators/services/KnownPathsService.ts 50% <0%> (ø)
...ocators/services/globalVirtualEnvronmentLocator.ts
src/client/common/utils/platform.ts 60% <0%> (+6%) ⬆️

@joyceerhl joyceerhl added the no-changelog No news entry required label Jan 6, 2021
@joyceerhl joyceerhl marked this pull request as ready for review January 8, 2021 17:15
@joyceerhl joyceerhl merged commit 9566c6e into microsoft:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants