Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick fix for native notebook support into release branch #15369

Merged
merged 3 commits into from
Feb 9, 2021
+3 −1
Merged

Cherry pick fix for native notebook support into release branch #15369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a20b5
Fix problem with notebook apis not being used. (#15366)
rchiodo Feb 9, 2021
25ee1f9
Update changelog
rchiodo Feb 9, 2021
22621cb
Remove news file
rchiodo Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
([#15232](https://github.com/Microsoft/vscode-python/issues/15232))
1. Ensure target environment is activated in the terminal when running install scripts.
([#15285](https://github.com/Microsoft/vscode-python/issues/15285))
1. Allow support for using notebook APIs in the VS code stable build.
([#15364](https://github.com/Microsoft/vscode-python/issues/15364))

### Code Health

Expand Down
2 changes: 1 addition & 1 deletion src/client/common/application/notebook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class VSCodeNotebook implements IVSCodeNotebook {
@inject(IDisposableRegistry) private readonly disposables: IDisposableRegistry,
@inject(IApplicationEnvironment) readonly env: IApplicationEnvironment,
) {
if (this.useProposedApi && this.env.channel === 'insiders') {
if (this.useProposedApi) {
this.addEventHandlers();
this.canUseNotebookApi = true;
}
Expand Down