Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start TensorBoard sessions with python.tensorBoard.logDirectory if any #15588

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Start TensorBoard sessions with python.tensorBoard.logDirectory if any #15588

merged 7 commits into from
Mar 12, 2021

Conversation

joyceerhl
Copy link

For #15476

@joyceerhl joyceerhl added the skip package*.json package.json and package-lock.json don't both need updating label Mar 8, 2021
@joyceerhl joyceerhl mentioned this pull request Mar 8, 2021
Closed
@joyceerhl joyceerhl marked this pull request as ready for review March 8, 2021 06:41
@karrtikr karrtikr self-requested a review March 9, 2021 02:17
karrtikr
karrtikr approved these changes Mar 11, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the scope of the setting is adjusted.

@joyceerhl joyceerhl requested a review from a team March 12, 2021 03:00
@joyceerhl
Copy link
Author

@karrtikr @paulacamargo25 Do I need two approvals from the Python extension team to merge?

@karrtikr
Copy link

Yes, I added @karthiknadig .

@karrtikr karrtikr requested a review from karthiknadig March 12, 2021 19:19
@joyceerhl joyceerhl merged commit f85d591 into microsoft:main Mar 12, 2021
@joyceerhl
Copy link
Author

Thanks y'all 😊

karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Mar 12, 2021
@joyceerhl @karthiknadig
Start TensorBoard sessions with user-level python.tensorBoard.logDire…
6ca45ef 
…ctory (microsoft#15588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@karrtikr karrtikr karrtikr approved these changes

@DavidKutu DavidKutu DavidKutu approved these changes

@paulacamargo25 paulacamargo25 Awaiting requested review from paulacamargo25

Assignees

@paulacamargo25 paulacamargo25

Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyceerhl @karrtikr @karthiknadig @DavidKutu @paulacamargo25