PTVS engine update + handling of the interpreter change #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
DonJayamanne
requested changes
May 4, 2018
| @@ -100,7 +127,7 @@ export class AnalysisExtensionActivator implements IExtensionActivator { | |||
| } | |||
|
|
|||
| if (downloadPackage) { | |||
| const downloader = new AnalysisEngineDownloader(this.services, analysisEngineFolder); | |||
| this.appShell.showWarningMessage('.NET Runtime is not found, platform-specific Python Analysis Engine will be downloaded.'); | |||
There was a problem hiding this comment.
Shouldn't this be an information message, instead of a warning?
| @@ -194,12 +222,15 @@ export class AnalysisExtensionActivator implements IExtensionActivator { | |||
| } | |||
| } | |||
|
|
|||
| // tslint:disable-next-line:no-string-literal | |||
| properties['DatabasePath'] = path.join(context.extensionPath, analysisEngineFolder); | |||
There was a problem hiding this comment.
No need to change, but you can avoid the linter messages if you define properties as follows:
const properties: {[key: string]:string} = {};
| } | ||
|
|
||
| private async downloadFile(location: string, fileName: string, title: string): Promise<string> { | ||
| const uri = `${location}/${fileName}`; | ||
| this.output.append(`Downloading ${uri}... `); | ||
| const tempFile = await createTemporaryFile(downloadFileExtension); | ||
|
|
||
| const deferred = createDeferred(); |
| @@ -96,4 +97,24 @@ export class FileSystem implements IFileSystem { | |||
| }); | |||
| }); | |||
| } | |||
|
|
|||
| public copyFileAsync(src: string, dest: string): Promise<void> { | |||
| return deferred.promise; | ||
| } | ||
|
|
||
| public deleteFileAsync(filename: string): Promise<void> { |
There was a problem hiding this comment.
Should we remove them all from IFileSystem? Currently we [sort of] follow node's 'fs' which has plain and Sync
src/client/common/platform/types.ts
Outdated
| @@ -44,4 +44,6 @@ export interface IFileSystem { | |||
| // tslint:disable-next-line:unified-signatures | |||
| appendFileSync(filename: string, data: {}, options?: { encoding?: string; mode?: string; flag?: string }): void; | |||
| getRealPathAsync(path: string): Promise<string>; | |||
| copyFileAsync(src: string, dest: string): Promise<void>; | |||
news/2 Fixes/1354.md
Outdated
| @@ -0,0 +1 @@ | |||
| Multiple fixes to format on type | |||
There was a problem hiding this comment.
I can't see any fixes for format on type or am I missing something.
Codecov Report
@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
- Coverage 71.62% 71.25% -0.37%
==========================================
Files 277 273 -4
Lines 12816 12759 -57
Branches 2299 2293 -6
==========================================
- Hits 9179 9092 -87
- Misses 3502 3526 +24
- Partials 135 141 +6
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Multiroot WS issue is still open in #1149)
This pull request: