Fix go to definition in Python notebooks #16385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
requested review from
DonJayamanne,
rchiodo,
DavidKutu and
IanMatthewHuff
karrtikr
approved these changes
Jun 3, 2021
kimadeline
approved these changes
Jun 3, 2021
|
FYI core team this PR also fixes this test failure on main https://github.com/microsoft/vscode-python/runs/2739474394 |
rchiodo
approved these changes
Jun 3, 2021
joyceerhl
added a commit
that referenced
this pull request
Jun 10, 2021
* Fix go to definition in Python notebooks (#16385) * notebook renamed to notebooks, notebooks symbols moved to workspace namespace * Drop usage of NotebookCellMetadata ctor * Update tests: `vscode.notebook.activeNotebookEditor` --> `vscode.window.activeNotebookEditor` (#16381) * vscode.window.activeNotebookEditor * window.visibleNotebookEditors * Remove deprecated `NotebookCellData` constructor parameter (#16390) * Update smoke tests and add CHANGELOG item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-jupyter#6108
Impacted by the following breaking API changes: