Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug, remove unnecessary flag, fix hash comparison on Linux #1734

Merged
merged 86 commits into from
May 23, 2018
Merged

Fix bug, remove unnecessary flag, fix hash comparison on Linux #1734

merged 86 commits into from
May 23, 2018

Conversation

MikhailArkhipov
Copy link

Fixes #1717

  • Remove flag that is obsolete
  • Fix case in hash comparison

This pull request:

  • Has a title summarizes what is changing
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #1734 into master will increase coverage by 0.21%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   73.56%   73.77%   +0.21%     
==========================================
  Files         279      279              
  Lines       13060    13049      -11     
  Branches     2328     2329       +1     
==========================================
+ Hits         9607     9627      +20     
+ Misses       3314     3289      -25     
+ Partials      139      133       -6
Impacted Files Coverage Δ
src/client/activation/downloader.ts 19.31% <ø> (+2.01%) ⬆️
src/client/activation/analysis.ts 15.26% <ø> (ø) ⬆️
src/client/common/configSettings.ts 88.09% <ø> (+0.44%) ⬆️
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/activation/hashVerifier.ts 23.52% <0%> (ø) ⬆️
src/client/formatters/lineFormatter.ts 98.36% <100%> (+0.06%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (ø) ⬆️
src/client/debugger/mainV2.ts 78.71% <0%> (+0.8%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9022527...d8c6193. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit eee1529 into microsoft:master May 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type formatter eats space in from .
3 participants