Proposed API for discovered python environments #18314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
reviewed
Jan 19, 2022
Comment on lines
+96
to
+101
| if (!query) { | ||
| // `undefined` query means this is full refresh of environments. | ||
| // Trigger an event indicating that we need to clear everything and start | ||
| // fresh. | ||
| reportInterpretersChanged([{ path: undefined, type: 'clear-all' }]); | ||
| } |
There was a problem hiding this comment.
@karthiknadig I disagree with the behavior here, I thought we agreed that hard refresh should not be a default behavior and should be behind a flag.
undefined query is used in several places like
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…hon#18314) * Proposed API initial commit * Add API description. * Adding tests initial * Added some tests * add getInterpreterDetails tests * Added tests for getInterpreterPaths * added tests for reportActiveInterpreterChanged * Tests for setActiveInterpreter * Add tests for reportInterpretersChanged * Tests for refreshInterpreters and getRefreshPromise * Add news item. * Update documentation and support for 'clear-all' event. * Fix tests and linting. * Fix logger tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17905