Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parso to 0.2.1 #1841

Merged
merged 4 commits into from
Jun 5, 2018
Merged

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 2, 2018

Fixes #1833
Fixes #1721

@brettcannon If updating Parso fixes #1721, should't we consider including this into the next release (delaying the release) or releasing a patch asap?
VS Code seems to plan releasing the Outline feature in the next version. If they do, then we'll have a larger (if not all) users facing the same issue of intellisense not working due to the outline feature.

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #1841 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage    74.3%   74.27%   -0.04%     
==========================================
  Files         282      282              
  Lines       13191    13191              
  Branches     2371     2371              
==========================================
- Hits         9801     9797       -4     
- Misses       3259     3263       +4     
  Partials      131      131
Impacted Files Coverage Δ
...reter/locators/services/cacheableLocatorService.ts 91.83% <0%> (-4.09%) ⬇️
src/client/debugger/mainV2.ts 77.91% <0%> (-0.81%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/Main.ts 52.34% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b097c1a...ba611d4. Read the comment docs.

@DonJayamanne DonJayamanne merged commit b12e9d1 into microsoft:master Jun 5, 2018
@derekwallace
Copy link

@DonJayamanne Updating parso to 0.2.1 does not fix #1721. It does prevent some error messages in the developer console.

@DonJayamanne DonJayamanne deleted the issue1833 branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to parso 0.2.1 Intellisense stops working for python files when using the new 'Outline' feature
3 participants